Repository navigation
Fix the crash when opening the box manager on a short box - #59
Open
gui-camargo wants to merge 1 commit into
Open
gui-camargo wants to merge 1 commit into
gui-camargo wants to merge 1 commit into
Conversation
Tapping the box name opens the box manager. Its neighbor cards read every cell of the 6x5 grid, and copying a box or counting a batch did the same. Gen 1 and Gen 2 international boxes hold 20 slots, and Let's Go holds 25, so the next slot threw and closed the app. Read only the slots the open save stores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash on tapping the box name.
The box name opens the box manager. Its neighbor cards read every cell of the 6×5 grid, and copying a box or counting a batch did the same. Gen 1 and Gen 2 international boxes hold 20 slots, and Let's Go holds 25. The next read throws ArgumentOutOfRangeException (box 0, slot 20 on Pokémon Blue) and the page closes.
The manager now reads only the slots the open save stores. The grid is still 6×5; the cells past the real box stay empty.
Reproduced on an AYN Thor with Pokémon Blue (INT), then checked again after the fix: tapping the box name opens the manager.