Repository navigation
Let a Red/Blue save choose its cartridge - #60
Open
gui-camargo wants to merge 1 commit into
Open
gui-camargo wants to merge 1 commit into
gui-camargo wants to merge 1 commit into
Conversation
Red, international Blue, Japanese Green and Japanese Blue are one save, so the shelf showed a single lumped cartridge. The player picks once, the same way FireRed/LeafGreen and Ruby/Sapphire already work. The shelf uses that cartridge's art, and a transfer records that origin. The file on disk is not rewritten. Rename still only changes the display name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53.
Red, international Blue, Japanese Green and Japanese Blue write the same file, so PKHeX keeps them as one group (RB). The shelf showed that group as a single cartridge, using the lumped Green art. Yellow was already its own save and stays that way.
Rename only changes the display name. The suggestion in that dialog comes from the file name, not from the save, and it does not set the cartridge art, the second-screen logo, or the origin recorded when a Pokémon is transferred. This uses the existing Set game path, the same one FireRed/LeafGreen and Ruby/Sapphire already use.
On the first open, the save asks which cartridge it is: Red, Blue (INT), Green (JP), or Blue (JP). Set game offers the same four, plus a Red/Blue-based ROM hack. Until a cartridge is chosen, the shelf keeps the G1 badge instead of the lumped Green art. After the choice, the shelf and the second screen use that cartridge's art. The choice is stored with the save and applied again the next time it is opened. The file on disk is not rewritten.
A transfer records the chosen game as the Gen 1 origin. Two limits come from PKHeX, not from the shelf:
Opening a Yellow save now records Yellow as the transfer origin. Before this, that origin fell back to Red.
Checked on an AYN Thor with a RetroArch Pokémon Blue (INT) save: it opens as that cartridge, under its own name, instead of the lumped Red/Blue group. The shelf in the photo also shows Yellow and Red as their own cartridges, and the lower screen is the Red logo.
Tests: SaveIdentity (30) and GameIdentification (27), including the four cartridges, file names that must not count as a choice, and the origin stamped on open.