Repository navigation
feat: Add source mapping option to unplugin - #2942
aleksanderkatan wants to merge 41 commits into
Conversation
|
pkg.pr.new packages benchmark commit |
Bundle size comparison (
|
| 🟢 Decreased | ➖ Unchanged | 🔴 Increased (max 0.03%) | ❔ Unknown |
|---|---|---|---|
| 0 | 343 | 12 | 0 |
No notable changes.
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.
251b52d to
bf24534
Compare
bf24534 to
5cf4bce
Compare
|
@pullfrog review |
This comment was marked as outdated.
This comment was marked as outdated.
4f8b9f0 to
4a82f63
Compare
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.80, 1.80, 3.86, 5.82, 7.32, 12.00, 23.51, 21.86]
line [0.86, 1.70, 3.54, 5.30, 7.00, 11.09, 21.91, 23.54]
line [0.85, 1.76, 3.57, 5.56, 6.43, 11.24, 22.19, 23.29]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.24, 0.46, 0.62, 0.74, 1.03, 1.03, 1.28, 1.42]
line [0.28, 0.47, 0.61, 0.73, 1.00, 1.06, 1.30, 1.38]
line [0.30, 0.47, 0.63, 0.75, 1.05, 1.09, 1.32, 1.39]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.74, 2.01, 3.35, 6.34, 11.50, 23.85, 53.83, 104.15]
line [0.76, 2.05, 3.32, 6.38, 11.83, 23.13, 52.00, 103.93]
line [1.05, 2.17, 3.85, 6.91, 11.69, 23.16, 50.70, 103.06]
|
|
@pullfrog review |
0a06a64 to
a4831e2
Compare
a4831e2 to
a4362b3
Compare
57abad1 to
2c746f2
Compare
5a66834 to
c80b81a
Compare
iwoplaza
left a comment
There was a problem hiding this comment.
Looks good! Just take a look at 🐸's comment about the warnings
I made the warning fire only once by adding a module scoped flag. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the single authored commit since the prior pullfrog review (9cbb21d), which fixes the test regression that review flagged.
- Webpack warning tests isolated —
test/sourceMaps.test.tsnow callsvi.resetModules()and re-importswebpackTransformbefore each warning assertion, so the module-globalwarnAboutSourceMapsOnceflag starts fresh per test. - New once-only coverage — a
[WEBPACK] warns only oncetest asserts the guard emits exactly one warning across two transforms. - Snapshot refreshed — the fallback-warning snapshot now matches the
[unplugin-typegpu]message text.
The prior CAUTION is resolved: pnpm vitest run --project='!browser' packages/unplugin-typegpu/ is green at 3159b8c (12 files, 179 passed). The previously open inline thread on sourceMaps.test.ts was retired.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Many changes relate to combining source maps (so that a correct location is displayed when another plugin fired before typegpu unplugin).
This works natively on Babel, and there is a workaround for rollup implemented. It does not work on webpack and some other plugins (we fall back to node position, this will still work as long as there was no other plugin before).