Repository navigation
Conversation
Import the structure parser in the directory branch and stop structure inputs from falling through to FASTA processing. Cover real structure fixtures and mixed directory traversal orders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_queries()accepts PDB and mmCIF files in an input directory, but those branches raiseUnboundLocalErrorbecauseproteinis only imported in the single-file branch. Import it lazily in the directory's structure-file branch as well.After appending a structure query, continue to the next file. Otherwise the parser falls through to the FASTA logic and accesses
seqs, which is either unbound or left over from a preceding FASTA file.Add regression tests under the existing
tests/directory that call the input module directly and use the repository's existing structure fixtures. They cover PDB/mmCIF directories, uppercase extensions, and mixed FASTA/structure directories in both filename orders. No model weights or network service are needed.Validation on Windows / Python 3.12.12 / alphafold-colabfold 2.3.23 / Biopython 1.85:
python -m pytest tests/test_input.py -q -p no:cacheprovider: 8 passed. All eight fail withUnboundLocalErrorbefore the fix.git diff --checkpasses.The full repository suite, GPU inference and upstream CI have not been run. No existing issue is linked; the failure was found while inspecting directory input handling.