Skip to content

test(ui-gate): pin the browser's locale to en-US - #168

Open
jrlanglois wants to merge 1 commit into
solutionsunity:mainfrom
jrlanglois:jrlanglois/test/ui-gate-locale
Open

jrlanglois wants to merge 1 commit into
solutionsunity:mainfrom
jrlanglois:jrlanglois/test/ui-gate-locale

Conversation

@jrlanglois

Copy link
Copy Markdown

The gate's gauge expectations are literals - eg: a cost of "$0.42", "50K" tokens - which are what en-US renders.

My machine - which is en-CA - puts "US$0.42" through Intl.NumberFormat, and 16 checks went red on a clean checkout at HEAD. This PR fixes the gate across all systems by pinning the locale to en-US.

The gate's gauge expectations are literals - eg: a cost of "$0.42", "50K" tokens - which are what en-US renders.

On my machine - which is en-CA - the formatted numbers come through a bit differently (eg: "US$0.42" through `Intl.NumberFormat`). This fails 16 checks a clean checkout at HEAD.

This PR fixes the gate across all systems by pinning the locale to en-US.

Signed-off-by: Joël R. Langlois <joel.r.langlois@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant