Repository navigation
fix(cards): align notes with the title, keep list numbers inside - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card notes were padded 24px on the left while the title row used the card size's own padding, so note text sat visibly right of the title. Both now take their horizontal padding from one per-size value (--card-pad-x), so they cannot drift apart.
A line such as "260720. The root disk ..." is an ordered list in Markdown. With the marker rendered outside the box and a fixed 1.2em indent, a six-digit number hung past the card's left edge and overlapped the card. Ordered-list markers in card notes now render inside the box.
Also removes two .node-card-notes rules no template referenced.
Tests: three new cases in cardNotes.test.js, proven red before the fix. Full suite, lint, prettier and vue-tsc pass.