Repository navigation
fix(notes): highlight markdown markup in the editor as documented - #191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detail panel guide promised Markdown syntax highlighting in Edit and Split mode, but the editor registered no highlight style, so every character rendered plain. In the proportional UI font the asterisk glyph is lighter and smaller than the letters, so
**Goals**looked like four oddly styled stars around a word instead of markup.The editor now applies a highlight style with fixed class names (utils/markdownHighlight.js): markers (
**,*,#,-,>, backticks, link brackets, table pipes) are dimmed to the tertiary text colour and never bold; bold text is bold, italic italic, headings bold, code monospace, links and URLs in the accent colour. Colours come from the theme variables, so light and dark themes both work.@codemirror/languageand@lezer/highlightwere already installed transitively and are now declared as direct dependencies, bounded below the next major. The lockfile gained only those two entries.Docs: the guide now states what is highlighted, and the claim that code blocks get language-specific colouring in Preview is removed because nothing implements it.
Tests: notesEditorHighlighting.test.js mounts the editor and checks the marker and content classes, plus the dependency declarations. All three failed before the change. Full suite, eslint, prettier and vue-tsc pass.