Repository navigation
fix(trash): make the per-item Delete permanent - #192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Trash view's Delete shared the
deleteevent with the other views, so App routed it to the soft-deletedeleteNodewith a node object, and the item stayed in the trash.docs/guides/views.mddocuments it as a permanent delete, anduseDataLoading.permanentlyDelete(confirmation + hard delete) existed but nothing called it.The event is now
delete-permanentlyend to end: TrashView -> ViewRenderer ->permanentlyDelete. New testsrc/__tests__/trashPermanentDelete.test.jswas red before the change.Also replaces CODEBASE-REVIEW.md with the 261015 review (the orphan-tag finding retracted as intended behaviour).