Skip to content

fix: push branches by full refname so a tag with the same name does not make them ambiguous #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
love-linger merged 1 commit into from
Oct 28, 2026
Merged

fix: push branches by full refname so a tag with the same name does not make them ambiguous #2826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Commands/Push.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public Push(string repo, Models.Branch local, Models.Remote remote, Models.Branc
if (noVerify)
builder.Append("--no-verify ");

builder.Append(remote.Name).Append(' ').Append(local.Name).Append(':').Append(remoteBranch.Name);
builder.Append(remote.Name).Append(" refs/heads/").Append(local.Name).Append(":refs/heads/").Append(remoteBranch.Name);
Args = builder.ToString();
}

Expand All @@ -38,7 +38,7 @@ public Push(string repo, Models.Commit revision, Models.Remote remote, Models.Br
if (force)
builder.Append("--force-with-lease ");

builder.Append(remote.Name).Append(' ').Append(revision.SHA).Append(':').Append(remoteBranch.Name);
builder.Append(remote.Name).Append(' ').Append(revision.SHA).Append(":refs/heads/").Append(remoteBranch.Name);
Args = builder.ToString();
}

Expand Down
2 changes: 1 addition & 1 deletion src/ViewModels/Push.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ private void PostSelectedRemoteChanged()
{
target = new Models.Branch()
{
Name = mergeTarget,
Name = mergeTarget.StartsWith("refs/heads/", StringComparison.Ordinal) ? mergeTarget.Substring(11) : mergeTarget,
Remote = _selectedRemote.Name,
Head = "---", // Not used by `git push` command but used by Views
};
Expand Down