fix: dispose renderer-owned geometry in SparkRenderer - #410
Draft
ArisLiWind wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a GPU resource leak in
SparkRenderer.dispose()by releasing the renderer-ownedSplatGeometrycreated in the constructor.Root cause
SparkRendererconstructs its ownSplatGeometry:That geometry is owned by the renderer instance, but
dispose()previously released render targets, textures, workers, accumulators, and pager state without disposing the geometry itself.Because
SplatGeometryallocates both apositionattribute and anindexbuffer, each create/dispose lifecycle could leave two WebGL buffers behind.Fix
Store the constructor-created geometry as renderer-owned state and dispose it during
SparkRenderer.dispose().Regression coverage
Added tests to verify that:
SparkRenderer.dispose()releases its internal geometrydispose()is safe to call multiple timesValidation
npm testnpm run lint -- --reporter=summary