Repository navigation
feat: choose upstream credentials for apps that sign in without a browser - #8042
Merged
danielkov merged 124 commits intoOct 30, 2026
Merged
Conversation
Administrators can create remote_session, service_account, static_credential and pass_through auth clients, offer an existing client on another server, and replace an administrator-created client's headers. The typed resolver treats administrator-created clients and associations as authoritative instead of checking them against the server settings that backfilled copies mirror.
Server settings add a credential another server already offers or create a new one, and a credential's sheet edits and rotates its headers. The static Authorization identity choice is renamed to a shared credential. Agent pages edit credential blocks for managers and connection owners.
…o daniel/aim-596-feat-dashboard-auth-client-setup
Where typed auth client resolution is enforced, consent offers each server's permitted auth clients, preselects the remembered choice or the fixed order, and records the picked client and its own registration on the new credential. Gateways offer the choice per member and capture tools through it.
A member added after a credential was issued gets no-auth or its single ready permitted client recorded atomically the first time it is used, where typed auth client resolution is enforced. Otherwise it stays unavailable until the person reconnects to choose.
Agent key creation records an auth client choice per server under a new api_key credential kind, rotation copies it, and under enforcement the key is served through those choices on direct servers and agent gateway members. The key wizard asks for a credential on servers offering several.
…wser Token requests name a per-server choice with upstream_auth_client; issuance profiles let an admin choose for an OAuth client or workload subject; with neither, the only ready credential is used, else selection_required.
Contributor
🦋 Changeset detectedLatest commit: ea2f8b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
Demo
What it shows:
|
Contributor
Author
|
Choosing for a workload: only shared credentials are offered, because a workload acts for nobody. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed
This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 73 files
Requires human review: Auto-approval blocked because this review re-detected 6 unresolved issues already reported by Cubic.
View guided diff | Turn on auto-fix | Re-trigger cubic
Bind a registration's issuer to the client's project, refuse empty header entries, keep stored secrets across '_'/'-' spellings, report members' choice among several credentials in get_my_mcp_connection_status, map the post-offer read failure, and cover admin clients and cross-server offers.
…o daniel/aim-596-feat-dashboard-auth-client-setup
…aniel/aim-596-feat-consent-auth-client-picker
Let an agent approval proceed when only the person lacks access, offer connect and reconnect for identity-provider clients, record no client for a no-auth server, and let a later no-auth approval clear the remembered client.
…niel/aim-596-feat-gateway-new-member-choices # Conflicts: # server/internal/mcpservers/upstreamclients/queries.sql
…o daniel/aim-596-feat-dashboard-auth-client-setup
…aniel/aim-596-feat-consent-auth-client-picker
…niel/aim-596-feat-gateway-new-member-choices
…niel/aim-596-feat-agent-key-auth-client-choices
… daniel/aim-597-mig-issuance-selection-profiles
…niel/aim-597-feat-headless-auth-client-choices
This comment has been minimized.
This comment has been minimized.
daviddanialy
approved these changes
Oct 26, 2026
daviddanialy
left a comment
daviddanialy
left a comment
Contributor
There was a problem hiding this comment.
approved for prod iterating behind feature flag
Drops the "New:" prefix, names the reuse option "Existing credential" and leaves it out when no other server has a credential to share. The upstream sign-in row now says what probing a remote upstream found.
…aniel/aim-596-feat-consent-auth-client-picker
…niel/aim-596-feat-gateway-new-member-choices
…niel/aim-596-feat-agent-key-auth-client-choices
… daniel/aim-597-mig-issuance-selection-profiles
…niel/aim-597-feat-headless-auth-client-choices
…suance-selection-profiles Regenerate the issuance selection profiles migration on top of main (SQL unchanged).
Base automatically changed from
daniel/aim-597-mig-issuance-selection-profiles
to
main
October 29, 2026 22:32
…choices # Conflicts: # server/internal/demoseed/queries/04_servers.sql # server/internal/demoseed/repo/09_postflight_identity.sql.go # server/internal/platformmcp/queries.sql
Contributor
There was a problem hiding this comment.
cubic analysis
All reported issues were addressed across 78 files
Linked issue analysis
Linked issue: AIM-597: feat: establish explicit auth choices for headless token issuance
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Honor explicit per-server choices on supported token grants | The ID-JAG and workload grant handlers parse per-server choices and pass them to the headless resolver. |
| ✅ | Use profiles or a sole ready option; never guess | The resolver follows request, profile, then unambiguous-ready-credential order and returns selection-required instead of consent preselection. |
| ✅ | Validate access and readiness before recording session choices | The resolver validates choices across targeted servers before recording them; invalid access or setup returns an error. |
| ✅ | Configure caller-scoped profiles through management and admin tools | The PR adds profile list, set, and delete APIs, dashboard controls, and a Platform MCP credential-choice tool. |
| ✅ | Keep inbound EMA separate; restrict workloads to shared credentials | The token handler treats inbound EMA as identity only, while workload profiles are limited to shared credentials. |
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2026
danielkov
deleted the
daniel/aim-597-feat-headless-auth-client-choices
branch
October 30, 2026 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIM-597 (2 of 2)
Stacked on #8041.
Summary
upstream_auth_client=<mcp_server_id>:<auth_client_id|none>, repeatable (at most 100). A choice for a server the token does not reach isinvalid_request.access_denied, one not connected or set up issetup_required; neither is silently replaced.selection_required, naming the server.authClients.listIssuanceProfiles/setIssuanceProfile/deleteIssuanceProfile, org:admin to write): one per OAuth client, or per workload issuer and subject, on a sign-in. Choices are stored inupstream_client_selectionsunder a newissuance_profilecredential kind. A workload acts for nobody, so its profile takes shared credentials only. Choices grant nothing: each issuance checks access again. Audited asissuance-selection-profile:create|update|delete.upstreamclients.CheckConfiguredChoiceis now shared by agent keys and profiles.upstream_auth_enforcedis on. Elsewhere nothing is decided at issuance, and a request naming a choice is refused rather than ignored.choose_mcp_headless_caller_credential(org admin, external only), next tooffer_mcp_upstream_credential. It previews the server's credentials and every headless caller's choice, then changes one caller's choice for that one server through the same serialized write the API uses, so the caller's other servers keep theirs.Motivation
RFC sections 7.5 and 7.6: callers that cannot see the consent picker still need a definite credential per server. That credential comes from the request, from an admin-configured profile, or from an unambiguous default. Without one, the request fails with an actionable error instead of a silent guess.
Gutternote review steps
🚀 Preview Environment (PR #8042)
Preview URL: https://pr-8042.dev.getgram.ai
Gram Preview Bot