Skip to content

feat: add code mode connection recovery - #8215

Open
ThomasRooney wants to merge 4 commits into
mainfrom
feat/codemode-reconnect
Open

ThomasRooney wants to merge 4 commits into
mainfrom
feat/codemode-reconnect

Conversation

@ThomasRooney

@ThomasRooney ThomasRooney commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Enrich tools.servers() with separate consent and authentication state plus recovery instructions. Add tools.connect(server=...) to return a short-lived browser URL bound to the requesting user and member. The execute description shows how to discover a blocker and obtain its link in one Python execution; no separate status helper or native MCP tool is added.

Inventory reports known metadata without upstream probes or credential refresh. Connection changes preserve pagination cursors. Visible members needing approval remain discoverable with an empty tool allowlist or expired catalogue; business-tool authorization remains enforced separately. Renewing catalogue consent still requires reconnecting the gateway in the MCP client.

The runner protocol moves to version 2. Deploy the matching runner image with the server.

Private Reflow review app contains the synthetic end-to-end walkthrough, retained test reports and rollout notes.

Motivation

An agent encountering consent_required needs an actionable recovery path. Including connection metadata in normal server discovery removes a separate status lookup, and connect supplies the user handoff without replaying a program or widening tool permissions.


🚀 Preview Environment (PR #8215)

Preview URL: https://pr-8215.dev.getgram.ai

Component Status Details Updated (UTC)
✅ Database Ready Existing database reused 2026-10-29 20:41:23.
✅ Images Available Container images ready 2026-10-29 20:42:57.

Gram Preview Bot

Keep connection status and browser sign-in inside the Python host API. Recovery does not grant member tool access or replace client catalogue consent.

Runner protocol 2 carries the new helpers; deploy the matching runner image with the server.
@ThomasRooney ThomasRooney added the enhancement New feature or request label Oct 28, 2026
@changeset-bot

changeset-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 850ed1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 39 files

This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread server/internal/mcp/serve_meta_code.go Resolved
Comment thread agents/code-runner/README.md Resolved
@blacksmith-sh

This comment has been minimized.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 17 files (changes from recent commits).

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread server/internal/mcp/serve_meta_code.go Resolved
Comment thread server/internal/codemode/host.go Resolved
Comment thread server/internal/codemode/catalog.go Resolved
Comment thread server/internal/codemode/catalog.go Resolved
@ThomasRooney
ThomasRooney marked this pull request as ready for review October 28, 2026 12:33
@ThomasRooney
ThomasRooney requested a review from a team as a code owner October 28, 2026 12:33

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 19 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

@ThomasRooney ThomasRooney added preview Spawn a preview environment preview-code-mode Give this PR's preview a Code Mode runner pool labels Oct 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request preview Spawn a preview environment preview-code-mode Give this PR's preview a Code Mode runner pool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants