Repository navigation
mig: drop the toolset MCP hosting columns - #8252
Open
daviddanialy wants to merge 6 commits into
Open
daviddanialy wants to merge 6 commits into
daviddanialy wants to merge 6 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🦋 Changeset detectedLatest commit: ceb048c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
E2E on the same migration SQL (regenerated since with a later timestamp; byte-identical), local lane. Old binary = #8248's head, since this ships after it.
|
Contributor
|
|
||||||||||||||||
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
|
||||||||||||||||
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 6 files
This PR changes a database schema or migrates data. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
View guided diff | Turn on auto-fix | Re-trigger cubic
…cy-alias' into daviddanialy/aim-671-drop-toolset-hosting-columns
…cy-alias' into daviddanialy/aim-671-drop-toolset-hosting-columns # Conflicts: # server/migrations/atlas.sum
This comment has been minimized.
This comment has been minimized.
…ialy/aim-671-drop-toolset-hosting-columns # Conflicts: # server/database/sqlc_retired_columns.sql # server/migrations/atlas.sum
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ialy/aim-671-drop-toolset-hosting-columns
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIM-671
Summary
toolsets.mcp_slug,mcp_is_public,mcp_enabled,custom_domain_idanduser_session_issuer_id. Dropping them also removes themcp_slugcheck, the custom domain and session issuer foreign keys, the twomcp_slugunique indexes, the issuer index and the column comments.server/database/sqlc_retired_columns.sql. The okta entry stays, so the file and itssqlc.yamlreferences stay too. Regenerated sqlc output does not change, because every package already compiled against the retired columns..mise-tasks/project/reset.sh: delete theNOT EXISTScheck ontoolsets.user_session_issuer_id. A toolset's issuer now lives on its hostedmcp_serversrow, which the existingmcp_serverscheck already covers. mig: drop the unused MCP collection tables #8011 set the precedent for this kind of edit.Do not merge until #8248 (AIM-670) is deployed to prod and past its rollback window. Merged commits are promoted to prod together, so this must not ship in the same promotion as #8248: pods older than #8248 still read these columns. The column values are discarded; every live row is already mirrored on
mcp_servers.Motivation
The hosted MCP server and its endpoints now own hosting state. AIM-670 removed the last code that read these columns and moved them into
sqlc_retired_columns.sql. This PR is the contract step.Atlas lint gives warnings only: BC104, CD102, and PG103 for the indexes that go away with the columns. Destructive statements carry
-- atlas:nolint DS103, as in #8011 and #8020.🤖 Generated with Claude Code
Summary by cubic
Drops the retired toolset MCP hosting columns from
toolsets; hosted MCP servers now own this state.mcp_slug,mcp_is_public,mcp_enabled,custom_domain_id, anduser_session_issuer_id, along with themcp_slugcheck, the foreign keys tocustom_domainsanduser_session_issuers, the twomcp_slugunique indexes, the issuer index, and their column comments.sqlc_retired_columns.sql; the okta statement stays.NOT EXISTScheck ontoolsets.user_session_issuer_idfromreset.sh; the existingmcp_serverscheck already covers issuers.Migration
Do not merge until #8248 (AIM-670) is deployed to prod and past its rollback window; older pods still read these columns. The values are already mirrored on
mcp_servers, so no data is lost.Written for commit ceb048c. Summary will update on new commits.