Skip to content

fix: revert embedded Stripe checkout migration - #8257

Merged
alx-xo merged 1 commit into
mainfrom
fix/revert-embedded-stripe-checkout
Oct 29, 2026
Merged

alx-xo merged 1 commit into
mainfrom
fix/revert-embedded-stripe-checkout

Conversation

@alx-xo

@alx-xo alx-xo commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Revert feat: migrate hosted checkout to embedded form #7459 (9b80ab1) and restore hosted Stripe checkout.
  • Remove the embedded form and its new publishable-key requirement, preserving subsequent changes.
  • Follow up on the production image rollback in speakeasy-api/gram-infra#4796 so subsequent releases do not reintroduce the regression.

Motivation

The embedded checkout migration requires STRIPE_PUBLISHABLE_KEY, but the deployment configuration did not wire it into the server. Restore the previous checkout flow while the configuration and rollout are addressed.

Validation

  • Verified the staged diff exactly matched the inverse of feat: migrate hosted checkout to embedded form #7459.
  • mise run test:server ./internal/thirdparty/stripe/: 129 tests passed.
  • Diff and pre-commit checks passed. No database migrations changed.
  • End-to-end checkout has not yet been verified.

Gutternote review steps

  1. Use a sandbox organization with self-serve billing enabled, no active subscription, and an org-admin session.
  2. Open Billing and start checkout.
  3. Verify checkout redirects to Stripe-hosted Checkout rather than mounting an embedded form.
  4. Complete checkout using sandbox payment details and verify the dashboard reflects the subscription after webhook processing.

Summary by cubic

Reverts the embedded Stripe checkout migration from #7459 and restores the hosted flow, since deployment configuration never wired the required STRIPE_PUBLISHABLE_KEY.

Rollback details

  • Checkout redirects to Stripe-hosted Checkout again instead of mounting an inline form.
  • Removes the STRIPE_PUBLISHABLE_KEY requirement, the checkout status polling endpoint, and the embedded checkout UI.
  • Complete the production image rollback in speakeasy-api/gram-infra#4796 before future releases to avoid reintroducing this regression.

Written for commit 07984dc. Summary will update on new commits.

View guided diff Turn on auto-fix


🚀 Preview Environment (PR #8257)

Preview URL: https://pr-8257.dev.getgram.ai

Component Status Details Updated (UTC)
✅ Database Ready Created and validated 2026-10-29 01:23:23.
✅ Images Available Container images ready 2026-10-29 01:25:00.

Gram Preview Bot

Reverts commit 9b80ab1 (#7459). Restore hosted checkout while the required deployment configuration is addressed.
@alx-xo alx-xo added the bug Something isn't working label Oct 29, 2026
@changeset-bot

changeset-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 07984dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alx-xo
alx-xo marked this pull request as ready for review October 29, 2026 01:18
@alx-xo
alx-xo requested review from a team as code owners October 29, 2026 01:18
@alx-xo alx-xo added the review:bypass Merge without human review approval. Required status checks still apply. label Oct 29, 2026
@alx-xo
alx-xo enabled auto-merge October 29, 2026 01:18

@gram-bot gram-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: review:bypass label applied by @alx-xo. Required status checks still gate this merge.

@github-actions github-actions Bot added the preview Spawn a preview environment label Oct 29, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 99 files

This PR changes payment, billing, or quota logic. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread server/internal/usage/stripe_webhook.go
Comment thread server/internal/usage/create_stripe_checkout.go
Comment thread server/internal/usage/create_stripe_checkout.go
Comment thread server/internal/usage/manual_partner_review_test.go
Comment thread client/dashboard/src/components/trial-status-card.tsx
Comment thread client/dashboard/src/routes.tsx
Comment thread .mise-tasks/stripe/setup.mts
Comment thread server/design/usage/design.go
Comment thread server/internal/usage/stripe_webhook.go
Comment thread client/dashboard/src/components/billing/payg-plan-section.tsx
@alx-xo
alx-xo added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 94d980e Oct 29, 2026
98 of 118 checks passed
@alx-xo
alx-xo deleted the fix/revert-embedded-stripe-checkout branch October 29, 2026 01:36
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working preview Spawn a preview environment review:bypass Merge without human review approval. Required status checks still apply.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant