Repository navigation
Conversation
🦋 Changeset detectedLatest commit: d5a595c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
View guided diff | Turn on auto-fix | Re-trigger cubic
This comment has been minimized.
This comment has been minimized.
danielkov
force-pushed
the
fix/gateway-agent-member-credentials
branch
from
October 29, 2026 18:38
4acd324 to
d5a595c
Compare
qstearns
approved these changes
Oct 29, 2026
danielkov
force-pushed
the
fix/gateway-agent-member-credentials
branch
from
October 29, 2026 19:01
d5a595c to
c51a58c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep agent gateway requests bound to the member's selected or attached upstream credentials. Reject unavailable or unauthorized connections instead of falling through to anonymous upstream requests.
Impact
Missing, revoked, or replaced attachments fail closed. Same-source reconnects remain usable, and header-only, no-auth, and hosted members retain their existing credential paths.
Technical details
This PR depends on #8275 for atomic publication of typed authentication clients. Authorization checks use the existing catalog and exact attached connection without repairing authority during requests.
Summary by cubic
Enforces that agent gateway member requests stay bound to the member's selected or attached upstream credentials. Missing, revoked, or replaced attachments now fail closed instead of falling through to anonymous upstream requests, and client eligibility is scoped to the member's server so sibling-server or issuer-shared clients cannot supply credentials.
Written for commit c51a58c. Summary will update on new commits.