Repository navigation
fix(subagent): shut down children concurrently - #308
Merged
Merged
Conversation
danielkov
enabled auto-merge (squash)
October 25, 2026 00:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start all child cleanup tasks before awaiting their results during session shutdown, so slow child closes overlap instead of accumulating sequentially.
Technical details
Retain the existing five-second per-child timeout and cancellation-safe task ownership of children and capacity permits. Await every started cleanup task and propagate a failure without abandoning other children.
Add a gated ACP regression test that requires both children to receive close requests before either responds, covering normal completion and cancellation of the shutdown caller.