Skip to content

fix(subagent): shut down children concurrently - #308

Merged
danielkov merged 1 commit into
mainfrom
fix/concurrent-child-shutdown
Oct 25, 2026
Merged

danielkov merged 1 commit into
mainfrom
fix/concurrent-child-shutdown

Conversation

@danielkov

Copy link
Copy Markdown
Contributor

Summary

Start all child cleanup tasks before awaiting their results during session shutdown, so slow child closes overlap instead of accumulating sequentially.

Technical details

Retain the existing five-second per-child timeout and cancellation-safe task ownership of children and capacity permits. Await every started cleanup task and propagate a failure without abandoning other children.

Add a gated ACP regression test that requires both children to receive close requests before either responds, covering normal completion and cancellation of the shutdown caller.

@danielkov
danielkov enabled auto-merge (squash) October 25, 2026 00:22

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

Took 9 min 55 sec

@danielkov
danielkov merged commit 2eff960 into main Oct 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant