Skip to content

fix(python): stop defaulting env-var credentials to an empty string in usage snippets #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2ynn merged 2 commits into from
Oct 26, 2026
Merged

fix(python): stop defaulting env-var credentials to an empty string in usage snippets #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28628f7
fix(python): stop defaulting env-var credentials to an empty string i…
LukasParke Oct 21, 2026
a1b3f9c
Merge branch 'main' into fix/python-getenv-usage-snippet
2ynn Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changesets/1792608066-c6cfa9bb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
id: 1792608066-c6cfa9bb
features:
- envVarSecurityUsage
targets:
- pythonv2
type: fix
bump: patch
description: omit the empty-string default from os.getenv in usage snippets for optional security fields so an unset environment variable no longer sends an empty credential
author: LukasParke
date: "2026-10-21"
7 changes: 7 additions & 0 deletions templates/templates/pythonv2/includes/sanitization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2688,7 +2688,14 @@ registerTemplateFunc("paginationRequestNoneGuard", paginationRequestNoneGuard);
function languageSpecificEnvVarWrapping(
envVar: EnvVar,
additionalContext?: TemplateValueContext,
fieldDef?: FieldDef,
): string {
addImport("os", "");
if (
envVar.defaultValue === "" &&
(fieldDef?.Optional || fieldDef?.Nullable)
) {
return `os.getenv("${envVar.name}")`;
}
return `os.getenv("${envVar.name}", "${envVar.defaultValue}")`;
}
Loading