Skip to content

fix(java): write the Maven POM scm url with https:// #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2ynn merged 3 commits into from
Oct 27, 2026
+17 −7
Merged

fix(java): write the Maven POM scm url with https:// #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c8bb77
fix(java): write the Maven POM scm url with https://
2ynn Oct 26, 2026
ad72560
Merge branch 'test/config-validation-examples' into fix/java/scm-url
2ynn Oct 26, 2026
c595f0d
test(java): expect https:// in the rendered scm url
2ynn Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changesets/1793046459-276bb2d1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
id: 1793046459-276bb2d1
features:
- core
targets:
- javav2
type: fix
bump: patch
description: write the Maven POM scm url with https://
author: 2ynn
date: "2026-10-26"
8 changes: 4 additions & 4 deletions pkg/generate/java_publishing_links_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,25 +38,25 @@ func TestJavaPublishingLinksNormalizeGithubURL(t *testing.T) {
"canonical": {
githubURL: "github.com/acme/acme-java",
pomURL: "https://github.com/acme/acme-java",
scmURL: "github.com/acme/acme-java",
scmURL: "https://github.com/acme/acme-java",
scmConnection: "scm:git:ssh://git@github.com/acme/acme-java.git",
},
"scheme, www, .git and trailing slash": {
githubURL: "https://www.github.com/acme/acme-java.git/",
pomURL: "https://github.com/acme/acme-java",
scmURL: "github.com/acme/acme-java",
scmURL: "https://github.com/acme/acme-java",
scmConnection: "scm:git:ssh://git@github.com/acme/acme-java.git",
},
"uppercase scheme, www and .git": {
githubURL: "HTTPS://WWW.github.com/acme/acme-java.GIT",
pomURL: "https://github.com/acme/acme-java",
scmURL: "github.com/acme/acme-java",
scmURL: "https://github.com/acme/acme-java",
scmConnection: "scm:git:ssh://git@github.com/acme/acme-java.git",
},
"non-string value": {
githubURL: "123",
pomURL: "https://123",
scmURL: "123",
scmURL: "https://123",
scmConnection: "scm:git:ssh://git@123.git",
},
}
Expand Down
2 changes: 1 addition & 1 deletion templates/templates/javav2/auxiliary/publishing.gradle.stmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ afterEvaluate {
description = config.description
url = 'https://{{.LocalComputed.GithubURL}}'
scm {
url = '{{.LocalComputed.GithubURL}}'
url = 'https://{{.LocalComputed.GithubURL}}'
connection = 'scm:git:ssh://git@{{.LocalComputed.GithubURL}}.git'
}
licenses {
Expand Down
2 changes: 1 addition & 1 deletion zSDKs/sdk-javav2/.speakeasy/gen.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion zSDKs/sdk-javav2/publishing.gradle
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading