Repository navigation
chore: bump Go to 1.26.10 - #2144
Merged
Merged
Conversation
Go 1.26.10 blocks the compromised eMudhra/emSign intermediate CA keys in crypto/x509. Released CLI binaries are built with the go.mod version (setup-go go-version-file), so this bump puts the block into shipped binaries.
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Bumps Go from 1.26.8 to 1.26.10 in go.mod to pull in crypto/x509 blocks for compromised eMudhra/emSign CA keys; a one-line toolchain patch bump with tests clean, bounded and clearly beneficial.
View guided diff | Turn on auto-fix | Re-trigger cubic
AshGodfrey
approved these changes
Oct 21, 2026
AshGodfrey
left a comment
Contributor
There was a problem hiding this comment.
go.mod is the only pin and CI/release install from it. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The private keys of eight eMudhra (emSign) intermediate CA certificates were reported compromised (incident summary, Mozilla). Go 1.26.10 and 1.27.3 block those intermediates' public keys in
crypto/x509, so certificate chains through them no longer verify.Every release and CI workflow installs Go from
go.mod, so this bump puts the block into released CLI binaries.What changed
go.mod:go 1.26.8→go 1.26.10. No other Go version pins exist in the repository.Testing
With Go 1.26.10:
go build ./...andgo vet ./...pass;go mod tidymakes no changes.Summary by cubic
Bumps Go from 1.26.8 to 1.26.10 in
go.mod— the only Go version pin in the repo — to pull in thecrypto/x509block on the compromised eMudhra/emSign intermediate CA keys. Since builds resolve the Go version fromgo.mod, the block applies to released CLI binaries.Testing
go build ./...,go vet ./..., andgo mod tidyall pass with 1.26.10.Written for commit c3fb89e. Summary will update on new commits.