ecdsa_sigformat: note conversions canonicalize S to low-S - #21
Merged
Merged
Conversation
The four converters call secp256k1_ecdsa_signature_normalize, so a high-S signature does not round-trip byte-for-byte through them. Document this in the module header, which otherwise reads as pure format conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four signature-format converters call
secp256k1_ecdsa_signature_normalizeunconditionally, so they canonicalize S to its low value: a high-S signature does not round-trip byte-for-byte through them. The module header describes the functions only as format conversions, which reads as byte-preserving.This adds a note to the module header. Documentation only, no behaviour change.