Skip to content

fix: honour deprecated ParseErrorsWhitelist.UnknownFlagsHandling #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasaschan merged 1 commit into from
Sep 6, 2026
Merged

fix: honour deprecated ParseErrorsWhitelist.UnknownFlagsHandling #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ func (f *FlagSet) getUnknownFlagsHandling() UnknownFlagsHandling {
// then, check deprecated ParseErrorsWhitelist:
// if UnknownFlagsHandling is set, use it
if f.ParseErrorsWhitelist.UnknownFlagsHandling != ErrorOnUnknownFlag {
return f.ParseErrorsAllowlist.UnknownFlagsHandling
return f.ParseErrorsWhitelist.UnknownFlagsHandling
}

if f.ParseErrorsWhitelist.UnknownFlags {
Expand Down
16 changes: 14 additions & 2 deletions flag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,11 +542,16 @@ func testParseWithUnknownFlags(f *FlagSet, t *testing.T, setUnknownFlags func(f
}
}

func testParseWithUnknownFlagsAndPassToArgs(f *FlagSet, t *testing.T) {
func testParseWithUnknownFlagsAndPassToArgs(f *FlagSet, t *testing.T, setUp ...func(*FlagSet)) {
if f.Parsed() {
t.Fatal("f.Parse() = true before Parse")
}
f.ParseErrorsAllowlist.UnknownFlagsHandling = PassUnknownFlagToArgs
if len(setUp) == 0 {
f.ParseErrorsAllowlist.UnknownFlagsHandling = PassUnknownFlagToArgs
}
for _, s := range setUp {
s(f)
}
f.SetInterspersed(true)

f.BoolP("boola", "a", false, "bool value")
Expand Down Expand Up @@ -822,6 +827,13 @@ func TestIgnoreUnknownFlagsAndPassToArgs(t *testing.T) {
ResetForTesting(func() { t.Error("bad parse") })
testParseWithUnknownFlagsAndPassToArgs(GetCommandLine(), t)
}

func TestIgnoreUnknownFlagsAndPassToArgsBackwardsCompat(t *testing.T) {
ResetForTesting(func() { t.Error("bad parse") })
testParseWithUnknownFlagsAndPassToArgs(GetCommandLine(), t, func(f *FlagSet) {
f.ParseErrorsWhitelist.UnknownFlagsHandling = PassUnknownFlagToArgs
})
}
func TestFlagSetParse(t *testing.T) {
testParse(NewFlagSet("test", ContinueOnError), t)
}
Expand Down
Loading