Validate IP slice values before appending or replacing - #513
Merged
Merged
Conversation
tomasaschan
approved these changes
Sep 21, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPSlicerejects invalid addresses throughSet, but itsSliceValue.AppendandSliceValue.Replacemethods currently report success and insert nil IPs. A failed replacement also discards the previous valid values.Make the shared conversion helper return an error for an invalid address. Both operations validate before mutating the destination, matching the other numeric slice implementations. Add tests for invalid append, a partially valid replacement, unchanged state on error, and valid IPv4/IPv6 inputs with surrounding whitespace.
Validation on Windows with Go 1.27.1: both invalid-input regressions fail before the fix;
go test ./...andgo vet ./...pass after it.