fix: allow explicit empty numeric slice values - #514
Open
sb123sb123 wants to merge 1 commit into
Open
sb123sb123 wants to merge 1 commit into
sb123sb123 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #222
Passing --data= to numeric and duration slice flags currently attempts to parse an empty token, so callers cannot distinguish an explicitly requested empty slice from an omitted flag.
This change treats the first explicit empty value as a non-nil empty slice for duration, float32, float64, int, int32, int64, and uint slices. It preserves nil, empty, and populated defaults when the flag is omitted, and keeps repeated non-empty values appendable. Bool, string, IP, and CIDR slice types already accept this syntax.
A matching earlier PR (#512) was withdrawn by its author because the required CLA could not be completed; the issue remains open and this change is independently tested against the current master base.
Tests:
Limitations: the full repository test suite, GitHub Actions matrix, and lint workflow were not run locally.
AI assistance: OpenAI Codex (GPT-5.6 Luna).