Repository navigation
Conversation
clearHash now calls history.replaceState with the same arguments, so clearing the hash rewrites the current entry instead of pushing a new one. The useHash test mounts the hook with a share hash and expects replaceState to be called with the pathname and pushState not to be called. Fixes spring-io#571 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clearHash now calls history.replaceState with the same arguments, so clearing the hash rewrites the current entry instead of pushing a new one. The useHash test mounts the hook with a share hash and expects replaceState to be called with the pathname and pushState not to be called.
Opening a shared configuration link shows the Configuration Loaded notification, but pressing Back stays on start.spring.io and the notification appears again instead of returning to the previous site. This happens in Safari, Firefox, and Mobile Safari. After the share hash is applied, clearHash removes it with history.pushState(null, null, pathname). That adds another history entry for the same page, so Back returns to the hashed URL and the configuration-loaded path runs again.
Tests for this live in
start-client/src/components/utils/__tests__/Hash.js.Fixes #571