Fixed issue where JSONView does not work with @RepositoryRestController - #2595
Open
ruthst00 wants to merge 1 commit into
Open
Fixed issue where JSONView does not work with @RepositoryRestController#2595ruthst00 wants to merge 1 commit into
ruthst00 wants to merge 1 commit into
Conversation
…not work with @RepositoryRestController. Signed-off-by: ruthes00 <ruthes00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1260
Summary
Issue: spring-data-rest#1161 / DATAREST-891 —
@JsonViewannotations on@RepositoryRestControllermethods were silently ignored, causing all fields to be serialized regardless of the view constraint.Root Cause: Spring MVC's
JsonViewResponseBodyAdvicewas not registered in theRepositoryRestHandlerAdapter(the customRequestMappingHandlerAdapterused by Spring Data REST). Without it, the@JsonViewhint set byRequestResponseBodyMethodProcessorwas never picked up during response serialization.Changes Made
1. Core Fix —
RepositoryRestMvcConfiguration.javaimport org.springframework.web.servlet.mvc.method.annotation.JsonViewResponseBodyAdvicenew JsonViewResponseBodyAdvice()in theResponseBodyAdvicelist ofrepositoryExporterHandlerAdapter()2. Test Infrastructure — new files in
spring-data-rest-tests-jpaPersonViews.java— Jackson@JsonViewmarker interfaces (SummaryandFull) forPersonPersonSummaryController.java— A@RepositoryRestControllerwith aGET /people/summaryendpoint annotated with@JsonView(PersonViews.Summary.class), demonstrating the fixPerson.java— Added@JsonView(PersonViews.Summary.class)tofirstNameandlastNamefields3. Test —
JpaWebTests.javaPersonSummaryControllerinJpaContextInitializerhonorsJsonViewOnRepositoryRestControllerMethod()test that verifiesfirstName/lastNameare present andgender/created/siblings/fatherare absent from the summary view responseThe new test (
Tests run: 1, Failures: 0, Errors: 0) confirms the fix works correctly.