Repository navigation
Resolve empty single-entity mappings as null - #1535
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single-entity
@EntityMappingmethods now return a null_entitieselement when they complete empty, matching the nullable Federation entity list and batch mapping behavior. An internal marker preserves its position whileMono.zipassembles the results; only the final result is converted to null. Resolver exceptions and empty batch results retain their existing errors.Synchronous
nullsingle-entity results also resolve to null because they follow the same empty-publisher path asMono.empty().Tests
Added a mixed-result regression covering an empty
Mono, successful entities, and a resolver exception. Updated the existing synchronous-null assertion; batch error tests remain unchanged../gradlew :spring-graphql:checkstyleMain :spring-graphql:checkstyleTest :spring-graphql:test --tests 'org.springframework.graphql.data.federation.EntityMappingInvocationTests' --no-daemon./gradlew :spring-graphql:checkstyleMain :spring-graphql:test --no-daemon --max-workers=1Fixes #1516.