Repository navigation
GH-1964 - Report duplicate application module identifiers with descriptive error message - #1965
Open
abhiramaab wants to merge 1 commit into
Open
abhiramaab wants to merge 1 commit into
abhiramaab wants to merge 1 commit into
Conversation
…ers with descriptive error message. Closes spring-projectsgh-1964. Signed-off-by: Abhirama <abhiram.b@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two or more application modules resolve to the same module identifier,
ApplicationModulespreviously threw a generic JDKIllegalStateException: Duplicate key ...fromCollectors.toMap(...), dumping raw multi-line module strings without indicating which packages collided or how to resolve the conflict.This commit groups detected modules by identifier and validates uniqueness before building the internal module map. If any duplicate identifier is found, it throws a descriptive
IllegalStateExceptionlisting the colliding base packages in alphabetical order and suggesting resolution options (@ApplicationModule(id = …)or@Modulithic(useFullyQualifiedModuleNames = true)).Includes reproducer unit tests in
ApplicationModulesUnitTests.Closes gh-1964.