Skip to content

Delete NAnt-era build files and other legacy content - #378

Merged
lahma merged 2 commits into
mainfrom
4x/delete-legacy
Nov 3, 2026
Merged

lahma merged 2 commits into
mainfrom
4x/delete-legacy

Conversation

@lahma

@lahma lahma commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

This PR clears out content the Fallout build superseded long ago. It goes in before the Parlot PR (#375), which also edits build-support/. Net change: 611 files and about 150k lines deleted.

Removed

  • Repository root: the NAnt build (Spring.build, Spring.include, common-project.include, CopyLibToBinHelpers.include), Build-ci.cmd, build-release-all.cmd, appveyor.yml.old, Local.testsettings, the packaging and S3 scripts, .nuget/ and nuget-packages/.
  • build-support/: the installer, the NAnt tools, CruiseControl, NDepend, AppVeyor scripts and the *.nant files.
  • Kept in build-support/: build/ (Fallout), icons/, the integration-test SQL scripts, and tools/antlr-2.7.6, which the Parlot PR removes.
  • Other directories:
    • dev-support/ and templates/ (VS 2008-era templates).
    • doc/docx/.
    • The NAnt .build files under examples/.
    • The orphan test folders Spring.Web.Mvc.Tests and Spring.Data.NHibernate.Tests, which aren't in the solution.
  • lib/: pruned to the two NUnitAsp assemblies that Spring.Web.Tests and Spring.Web.Conversation.NHibernate5.Tests still reference.
  • Spring.Net.sln: the solution items for the deleted files are gone, along with the NAnt add-in and .vsmdi settings.

Before deleting anything, I searched the tree for references to it. Files that were still referenced were either unhooked first (the solution items) or kept (the lib/ DLLs).

Docs

  • AGENTS.md: "Legacy areas" now lists only doc/ and the ANTLR tool.
  • README.md: the release-contents list matches the current layout.

Verification

  • dotnet build Spring.Net.sln -c Debug and ./build.cmd Compile --skip CompileExamples are clean locally.
  • The examples need MSBuild 18 locally, so CI's CompileExamples on Windows is their check.

🤖 Generated with Claude Code

lahma and others added 2 commits November 3, 2026 14:03
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Marko Lahma <marko.lahma@gmail.com>
Drop the NAnt-era solution items (Spring.build, Spring.include,
common-project.include, Local.testsettings, the .nuget folder) from
Spring.Net.sln. Delete those files, nuget-packages/, dev-support/ and
the NAnt .build files under examples/.

Prune lib/ to the two NUnitAsp assemblies that Spring.Web.Tests and
Spring.Web.Conversation.NHibernate5.Tests still reference.

Rewrite the README's release-contents list for the current layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Marko Lahma <marko.lahma@gmail.com>
@lahma
lahma merged commit 2382d79 into main Nov 3, 2026
3 checks passed
@lahma
lahma deleted the 4x/delete-legacy branch November 3, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant