[lahma]

The SQL Server-backed integration suites now start their own database through Testcontainers for .NET. All they need is a running Docker daemon: no local SQL Server, no docker-compose, no hosts entry, no hand-run scripts. A new CI job runs them. This follows the Testcontainers setup that already works in Quartz.NET.

How it works

• test/Shared/SqlServerTestEnvironment.cs is linked into each integration project.
  • An assembly-level [SetUpFixture] starts one mcr.microsoft.com/mssql/server:2022-CU27-ubuntu-22.04 container per test assembly, with a random port, so projects can run in parallel.
  • It runs build-support/create-integration-test-databases-and-users.sql and the project's own Data/*_database.sql, splitting on GO and using the same SqlClient path for every script.
  • It publishes SPRING_TEST_SQLSERVER_HOST, _USER and _PASSWORD, plus SPRING_TEST_SQLSERVER_CS_<DATABASE> for each database.
  • If startup fails it disposes the container and rethrows the original error.
• The XML contexts resolve ${SPRING_TEST_SQLSERVER_CS_*} through VariablePlaceholderConfigurer / EnvironmentVariableSource, or through the existing PropertyPlaceholderConfigurers, where an environment variable is the fallback. C# tests call SqlServerTestEnvironment.GetConnectionString("Spring").
• The four projects no longer hard-code SPRINGQA or (local) hosts.
• Setting SPRING_TEST_SQLSERVER to an admin connection string runs the same, now idempotent, scripts against an existing server instead of a container. In that mode the build runs one test module at a time, because Microsoft.Testing.Platform otherwise runs the net472 and net10.0 modules at once.
• Only the four test projects reference Testcontainers.MsSql 4.16.0.

Projects

Project	Passed / skipped (both TFMs)
Spring.Data.Integration.Tests	69 / 31
Spring.Data.NHibernate5.Integration.Tests	22 / 26
Spring.Data.NHibernate5.NestedTxSuspension.Integration.Tests (net472)	2 / 1
Spring.Scheduling.Quartz3.Integration.Tests	2 / 0

Rot fixed along the way

• A formatter had corrupted every Data integration _database.sql script and the NHibernate5 SQL scripts, splitting identifiers across lines ([\n decimal]), so SQL Server rejected them. These suites could not have passed for years.
  • The scripts are rewritten with the same tables, columns, types, keys and stored procedures; the review checked them against the originals.
  • They are UTF-8 now instead of UTF-16.
• The Quartz 3.x SQL Server schema is copied unchanged from Quartz.NET v3.22.9 (Apache 2.0) into the Quartz3 project's Data/.
• Whitespace inside two mapping-resource values broke resource lookup.
• Two AppVeyor-era [Ignore]/[Explicit] attributes are removed.
• The Quartz job-store test only slept for 20 seconds. It now asserts the job actually ran.
• Five tests need MSDTC (distributed transactions), which can't work against a container. They are [Explicit("Requires MSDTC: …")]:
  • DTCTests and DTCTestsNoInterfaces .DeclarativeWithAttributes;
  • MultipleDbTests.MultipleDBAccess and .MultipleDBAccessUsingMultipleSessionScopes;
  • the nested-suspension NotSupported test.

Build and CI

• New Fallout target IntegrationTest runs just those four projects, with TRX output. Off Windows it runs net10.0 only and skips the net472-only project. It works locally as well as on CI.
• Test --test-integration-data now includes them. Before, the flag had no effect without --test-full. --test-integration-nms now matches the real Spring.Messaging.Nms.Integration.Tests name.
• New integration-linux job in ci.yml (ubuntu-latest, 30 min) runs ./build.sh Compile IntegrationTest and always uploads artifacts/TestResults. publish.yml is untouched.
• Deleted docker-compose.yml and the unused docker-compose-ci.yml. README "Running tests" and AGENTS.md "Integration tests" describe the new recipe.

Not in this PR: NMS/ActiveMQ integration on Testcontainers comes next. MSMQ tests stay Windows-only. Spring.Web.Conversation.NHibernate5.Tests uses SQLite and needs no container.

Verification

• ./build.cmd Compile IntegrationTest passes locally, net10.0 and net472.
• Ran twice against one server through SPRING_TEST_SQLSERVER (14 database setups on the same server), green both times.
• ./build.cmd Test passes. The only failure is FormatUsingDefaults, which depends on this machine's regional settings.
• spring-reviewer accepted it with follow-ups, which are in the last commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk