Repository navigation
Examples: delete dead example projects, document why two solutions are skipped - #393
Merged
Merged
Conversation
…nd WebQuickStart - Delete the empty test shells under Spring.MsmqQuickStart and Spring.NmsQuickStart (an AssemblyInfo.cs and a legacy csproj each, no tests) and remove them from the two solutions. - Delete Spring.Examples.Pool: it needs a prebuilt .NET 2.0 Spring.Threading.dll and LinqBridge, and builds on no supported framework. - Drop the CompileExamples skip list entirely, so SpringAir and Spring.WebQuickStart are compiled as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk Signed-off-by: Marko Lahma <marko.lahma@gmail.com>
…e reason Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk Signed-off-by: Marko Lahma <marko.lahma@gmail.com>
lahma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftovers from the examples cleanup (#385).
Spring.Examples.Pool. It can't build on any supported framework. It compiles against a .NET 2.0Spring.Threading.dllwhoseIExecutoruses LinqBridge'sAction, which fails with CS0012, and adding LinqBridge only turns that into CS0535/CS0433. Nothing outsidedoc/andchangelog.txtmentions it, and its skip entry in CompileExamples is gone.Spring.MsmqQuickStart/testand two inSpring.NmsQuickStart/test. Each had only anAssemblyInfo.csand a VS2005-era csproj, and no tests. They're also removed from the NMS solution.GetTargetPathon the outerTargetFrameworksbuild, which doesn't define it (MSB4057).aspnet_compiler, so making the solutions buildable would mean changing how the sites reference Spring. That's for a separate PR, if anyone wants it.binalready gets Spring's full net472 dependency closure next to the HintPath references, includingMicrosoft.Extensions.Logging.Abstractions8.0.0.3 andMicrosoft.Bcl.HashCode6.0.0.0.Verification:
Spring.Net.sln, the MSMQ and NMS example solutions and_build.csprojbuild in Release with 0 warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01LGkLQuAuUjvRjrU1AcTsmk