New features - keystones independent, wire holes independent, component offset(2nd try)#28
Open
0310njs wants to merge 6 commits into
Open
New features - keystones independent, wire holes independent, component offset(2nd try)#280310njs wants to merge 6 commits into
0310njs wants to merge 6 commits into
Conversation
- Add feature to allow user to remove or add the left and right keystones independently.
Add comments and dclean up code to new feature.
Add component_offset varible allowing user to move the component cutout left or right.
- Add feature that lets user remove or add wire holes independently
Found bug with offset not moving airholes on the side of chassie with the rest of the model. bug has been corrected.
- Use epsilon for coplanar face fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component offset paired with the keystones independent feature will allow the user to put one keystone next to a bigger component that would normally not fit with two on each side.