Skip to content

Bug 5553: Segfault when parsing valueless request_header_add #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rousskov wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −10
Open

Bug 5553: Segfault when parsing valueless request_header_add #2482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/cache_cf.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4512,20 +4512,19 @@ static void parse_HeaderWithAclList(HeaderWithAclList **headers)
if (hwa.fieldId == Http::HdrType::BAD_HDR)
hwa.fieldId = Http::HdrType::OTHER;

Format::Format *nlf = new ::Format::Format("hdrWithAcl");
ConfigParser::EnableMacros();
String buf = ConfigParser::NextQuotedToken();
const auto fieldValue = ConfigParser::NextQuotedToken();
ConfigParser::DisableMacros();
hwa.fieldValue = buf.termedBuf();
if (!fieldValue)
throw TextException("missing a required field-value parameter", Here());
hwa.fieldValue = fieldValue;
hwa.quoted = ConfigParser::LastTokenWasQuoted();
if (hwa.quoted) {
if (!nlf->parse(hwa.fieldValue.c_str())) {
self_destruct();
return;
}
hwa.valueFormat = nlf;
} else
delete nlf;
// XXX: We leak memory when parse() throws due to a parsing failure.

@rousskov rousskov Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This memory leak is an old out-of-scope bug. This PR does not make it worse.

hwa.valueFormat = new ::Format::Format("hdrWithAcl");
const auto parsed = hwa.valueFormat->parse(hwa.fieldValue.c_str());
Assure(parsed); // parse() never returns false for a freshly created hwa.valueFormat
}
aclParseAclList(LegacyParser, &hwa.aclList, (hwa.fieldName + ':' + hwa.fieldValue).c_str());
(*headers)->push_back(hwa);
}
Expand Down
Loading