Repository navigation
feat(mcp): guide full setup and car departure goals - #44
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assistants can now begin a full setup interview, explicitly discover/test equipment and complete draft-bound MyUplink sign-in using the connected box's setup service.
setup_beginrequests diagnostic and setup rights together, preserves an existing draft and guides an owner with no connected box through local assistant setup and Cloud consent.car_goal_requestadds target charge, local departure time, weekdays and solar-only choices through the existing car.goal.set owner-request path. Local Settings → Access and the FTW app can approve lasting changes. The public profile exposes the same named setup and car-goal tools. Ordinary use starts no setup interview.Paired Core: srcfl/ftw#1747. Uses existing protocol messages and scopes; older boxes refuse unsupported actions. Deploy with the paired Core beta after its final UI check. No public directory approval or hardware support is implied.
Validation: full
go vet ./...,go test -race ./...,go test -tags ftwclouddev ./..., andscripts/check-imports.shpassed. The last schema/copy changes also passed the full MCP suite. Tests cover OAuth/Noise setup grants, revision preservation, preparation actions, public-profile listing/execution, typed car schedules, invalid arguments and owner approval. Service growth: 125 net Go lines without tests, all in internal/mcp; no key, store or uplink changes.