Repository navigation
Fix MCP charging duration reports - #45
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An FTW plugin test requested a 2,300 W charge for ten minutes. Core received a 600-second hold, but MCP labeled the command's 900-second lease as
endsInSeconds. ChatGPT then reported a fifteen-minute charge.Return
requestedHoldSecondsfor charging requests and name the acknowledgement deadlineleaseExpiresInSeconds. Explain that the lease does not establish charging duration or measured power. Release calls report no requested hold. Commands, caps and Core enforcement stay unchanged. Production Go grows by ten net lines.Validation:
go vet ./...,go test -race ./...,go test -tags ftwclouddev ./..., andbash scripts/check-imports.shpassed. Regression coverage distinguishes a 600-second hold from a 900-second lease and checks release and acknowledgement-only responses. The real ChatGPT run remains failed pending deployment and retest.