Repository navigation
fix(pairing): connect one iPhone with a code and clear restart - #1721
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
frahlg
marked this pull request as ready for review
October 18, 2026 06:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owner with only an iPhone cannot scan the QR shown in Safari on that phone. Turning on the app link also needs a restart, but the action is hard to find after dismissing the save dialog.
The app tab now offers a direct iPhone link, an explicit copy action, and an eight-character pairing code with the box address. The iPhone exchanges that code directly with the box on the home Wi-Fi. The exchange keeps the code's role, expiry and five-guess limit, replaces it once with a full 128-bit enrollment token, and keeps the existing local-address, house-password and browser-origin checks. App sessions and proxies cannot claim it. No short-code hash or trust material goes through a cloud lookup.
Save and restart FTW stays beside the setting. It saves before restarting, shows progress, handles a refusal and returns to the app tab after reload. Code and copy actions stay visible when the buttons wrap on a phone.
Paired iOS change: srcfl/ftw-app#90. The short-code path needs both changes; the QR format stays v3.
Validation:
make verify: passed.npm test: 776 passed.Human UI review and a physical iPhone check remain. This PR does not publish a beta.