Repository navigation
fix(history): keep P1 household and PV energy observations - #1730
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A P1/HAN-only meter with
read_battery: falsecould still require battery power when stored capacity or telemetry-only settings remained. That made household history incomplete even while grid and PV reports continued. Honor the explicit reading setting, while still rejecting a battery flow that has actually reported and then gone stale.A PV meter reporting generation together with a zero cumulative register also wrote zero energy. Use bounded power integration in that case, labelled
power_telemetry/integrated. Keep valid positive counters authoritative. When a usable counter first arrives, close only the final observed power interval and use the counter as a new baseline, avoiding both a lost interval and double counting.Validation:
v0.151.0-beta.1(19a36f11) and on the local combined candidate before the fix.appHistory.Windownow retain household data; two minutes at 3 kW produce 100 Wh instead of zero.make verifyand targeted race checks pass. Counter cursors also survive closing and reopening SQLite, including a zero cursor left by the previous Core.This does not rewrite old history, change the driver pin, alter SQLite budgets or change an app view. Customer hardware and any historical recovery still need their own evidence.