Skip to content

fix(chargers): surface missing saved connections - #1743

Merged
frahlg merged 1 commit into
masterfrom
codex/charger-binding-diagnostics-20261019
Oct 19, 2026
Merged

frahlg merged 1 commit into
masterfrom
codex/charger-binding-diagnostics-20261019

Conversation

@frahlg

@frahlg frahlg commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

When a charger kept the name of a removed or renamed driver, Settings showed it as a saved connection and validation gave no warning. Settings now marks the missing connection, keeps the warning after save, and clears it when the owner chooses a configured charger or removes the entry. The saved choice stays intact. An unseen OCPP identity remains unverified.

Setup validation now saves warnings even when it leaves the settings bytes unchanged, and binds those warnings to the reviewed draft revision. The diagnostic catalogue includes exact saved charger names and their binding status, plus the full-read workflow an assistant needs to check them.

Paired Cloud change: srcfl/ftw-cloud#41 (MCP guidance and diagnostic refusal handling).

Validation:

  • Full make verify passed.
  • All 857 web tests passed.
  • Targeted config, onboarding and API race tests passed.
  • Browser comparison used the real Settings scripts with a local fixture: the missing connection warns, choosing easee_cloud saves the new binding and removes the old option and warning; the narrow view has no horizontal overflow.

Fredrik reviewed the rendered UI and approved both paired merges on 19 October 2026. The local preview uses no private site data. Release, Cloud deployment and box installation remain separate steps.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T04:51:53.983341Z 9243121 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant