Repository navigation
fix(chargers): flag disabled saved connections - #1746
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A charger whose saved driver is disabled now keeps an explicit warning in Settings and setup validation. The diagnostic catalogue reports
disabledseparately from a missing name or an unseen OCPP charger. The saved binding and driver state stay intact until the owner changes them.Regression tests cover warning persistence and review, re-enabling/removing the driver, OCPP ambiguity, and the actual measurement topology: a missing EV source stays unknown until an explicit repair supplies fresh EV power. A small test-only Core server lets the paired Cloud tests run MCP through these real read handlers and temporary SQLite history.
Fixes #1744. Paired Cloud PR: srcfl/ftw-cloud#43 (fixes srcfl/ftw-cloud#42). Its scoped, redacted measurement diagnostics run against this exact Core commit.
Validation: full
make verify, all 858 web tests, and focused config/onboarding/API/topology race tests passed. The paired OAuth/TLS/Noise test passed against real Core handlers and SQLite for missing, disabled and repaired bindings, including an incomplete source interval.Browser preview confirms the disabled warning and a narrow layout without horizontal overflow. Fredrik reviewed the rendered disabled-driver warning and approved it on 19 October 2026. No release, deployment or box update is part of this PR.