Skip to content

fix(chargers): flag disabled saved connections - #1746

Merged
frahlg merged 1 commit into
masterfrom
codex/charger-quality-followup-20261019
Oct 19, 2026
Merged

frahlg merged 1 commit into
masterfrom
codex/charger-quality-followup-20261019

Conversation

@frahlg

@frahlg frahlg commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

A charger whose saved driver is disabled now keeps an explicit warning in Settings and setup validation. The diagnostic catalogue reports disabled separately from a missing name or an unseen OCPP charger. The saved binding and driver state stay intact until the owner changes them.

Regression tests cover warning persistence and review, re-enabling/removing the driver, OCPP ambiguity, and the actual measurement topology: a missing EV source stays unknown until an explicit repair supplies fresh EV power. A small test-only Core server lets the paired Cloud tests run MCP through these real read handlers and temporary SQLite history.

Fixes #1744. Paired Cloud PR: srcfl/ftw-cloud#43 (fixes srcfl/ftw-cloud#42). Its scoped, redacted measurement diagnostics run against this exact Core commit.

Validation: full make verify, all 858 web tests, and focused config/onboarding/API/topology race tests passed. The paired OAuth/TLS/Noise test passed against real Core handlers and SQLite for missing, disabled and repaired bindings, including an incomplete source interval.

Browser preview confirms the disabled warning and a narrow layout without horizontal overflow. Fredrik reviewed the rendered disabled-driver warning and approved it on 19 October 2026. No release, deployment or box update is part of this PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T05:45:27.150659Z bf80760 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant