Repository navigation
fix(web): remove the timing note under the energy flow - #1752
Merged
Merged
Conversation
The Overview showed a long line under the diagram with the current balance, a 10 s energy mean, its clock range, age, basis and timing caveats. It repeated the house value and read as debug output. Home use still shows current power, marked estimated, and the diagram still shows missing or paused data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On v0.154.0-beta.1 the Overview prints a long line under the energy-flow diagram:
It repeats the value already shown in the house node and reads as debug output. Fredrik asked to remove it.
Change
homeEstimateNoteand its helper fromweb/components/energy-flow-readings.js.web/app.jscreated under#energy-flow.What stays:
status.load_estimateand the API are unchanged.House load, estimated).no data) and pauses when data is not live.The web app and the iOS app never showed this text, so they need no change.
Evidence
node --test 'web/**/*.test.mjs': 864 pass, 0 fail.master'sweb/and this branch'sweb/locally with a proxy that forwarded only GET requests to the home box, so both rendered the same live data. Onmasterthe note sat under the diagram. On this branch the card ends below the diagram, and the house still shows ≈ 2.8 kW.🤖 Generated with Claude Code