Repository navigation
fix(drivers): bundle easee_cloud 1.3.8, the 7 A start for a 6 A order - #1811
Merged
Merged
Conversation
Move the device-drivers pin from 5cc7bb1a to 219c462e (srcfl/device-drivers#190 and #191). Between the two pins only easee_cloud changed. An Easee Cloud charger given a 6 A order now starts at 7 A per phase when Core's cap_amps_per_phase (#1809) allows 7 A, which avoids Easee's roughly five-minute delay at 6 A, and steps down to 6 A once the charger reports charging or after 90 s. 1.3.8 adds two review fixes: no 7 A before the first poll, and a pause or stand-down cannot leave 7 A for the phaseMode re-assert. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the device-drivers pin in
drivers/BUNDLED_SOURCE.jsonfrom5cc7bb1ato219c462e, so the next beta carries easee_cloud 1.3.8. Between the two pins onlyeasee_cloudchanged: srcfl/device-drivers#190 (1.3.7) and srcfl/device-drivers#191 (1.3.8).What users get
Easee's firmware waits about five minutes before it starts a car at 6 A. On an Easee Home with an Audi e-tron the delay was 5 min 2 s to 5 min 47 s in four runs on 22 October 2026. The driver now offers 7 A per phase for a 6 A start, and only when Core's
cap_amps_per_phase(#1809) allows 7 A, as well as the order'smax_amps_per_phaseand the charger's static limit. It steps down to 6 A as soon as the charger reports charging, or after 90 s. A charger on a phase without room for 7 A starts at 6 A as before.start_boost: falsein the driver config turns it off.1.3.8 adds two fixes from the review of #190:
Tests
scripts/sync-bundled-drivers.shat219c462e: 44 drivers written,easee_cloudreads 1.3.8.--checkpasses.go test ./internal/drivers/... ./internal/driverrepo/... ./internal/fleetping/...: pass.go generate ./internal/fleetping/leavesshipped_gen.gounchanged, because the driver list did not change.TestSiteSimFieldMatrix: all 340 cases match the known rows, so nothing changed. The matrix models Easee in Go (sitesim.EVSE) and does not run the Lua file, so a driver pin cannot change its result.drivers/tests/lua_harness/test_easee_cloud_start_boost.lua. Not yet run on hardware with 1.3.8.Overlap
#1792 and #1537 also move this pin, for unmerged Easee driver branches. Whichever merges last gets a conflict in
BUNDLED_SOURCE.json.🤖 Generated with Claude Code