Repository navigation
refactor: Replace minio/mc with garage/rclone - #459
Merged
Merged
Conversation
Also use drawio.png suffix to make the images easier to edit. spark-k8s-anomaly-detection-taxi-data/overview.drawio.png was made from scratch as it didn't contain the source before.
Note: Using a single node deployment. If the big demo really needs replicas, we will need to adjust how we bootstrap the Garage cluster
1 task done
Also a ServiceMonitor, and expose Garage metrics via a dedicated Service.
…ates in the rendered docs
NickLarsenNZ
marked this pull request as ready for review
October 7, 2026 13:07
Member
Author
|
We could look at putting the Garage helm chart somewhere so we can |
sbernauer
requested changes
Oct 8, 2026
sbernauer
left a comment
Member
There was a problem hiding this comment.
May thanks for this PR, it surely was a big effort.
I also like all of the small cleanups. The only "real" problems are related to missing icons in images
sbernauer
approved these changes
Oct 8, 2026
sbernauer
left a comment
Member
There was a problem hiding this comment.
Images now look good, thanks!
Member
Author
|
I merged too soon. @adwk67 has some suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
region-1as the S3 region to keep things vendor agnostic.rcloneoveraws-clito make it vendor agnostic. There were other options but they were less maintained.Testing
I ran parts of the demos to verify S3 read/write paths (except the big demo).