Skip to content

feat: Add universal navigation bar#149

Merged
xeniape merged 2 commits into
stackablefrom
feat/add-universal-header
Jul 2, 2026
Merged

feat: Add universal navigation bar#149
xeniape merged 2 commits into
stackablefrom
feat/add-universal-header

Conversation

@xeniape

@xeniape xeniape commented Jun 29, 2026

Copy link
Copy Markdown
Member

This PR adds the universal navigation bar, similar to the one in the HUB, mimicking its design and functionality, but adjusted some minor things compared to the HUB version:

  • GitHub link opens in a new tab (since it does not have the navigation bar to navigate back)
  • Clicking outside of the drop down menu, closes it
  • If the drop down menu is open and screen size changes to the desktop version, it does not display the lingering drop down menu
  • Change "Docs" menu item names to "Documentation"
  • Remove grey host labels from menu items in desktop version

@xeniape xeniape self-assigned this Jun 29, 2026
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Jun 29, 2026
@NickLarsenNZ

Copy link
Copy Markdown
Member

Do you have a screenshot available? Or can it be deployed somewhere?

@xeniape

xeniape commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Do you have a screenshot available? Or can it be deployed somewhere?

If it's not too much to ask I would prefer if you could build it and try it out (to catch things that don't work). For that you would go into the documentation repository, create a symlink ui to the local checkouted branch here (move the git module temporarily), and use the make build-truly-local command. But I can also attach a screenshot in a bit.

@xeniape

xeniape commented Jun 30, 2026

Copy link
Copy Markdown
Member Author
image image

Basically the same as in https://hub.stackable.tech/ but with the adjustments mentioned above

Comment thread src/partials/universal-nav.hbs
Comment thread src/partials/universal-nav.hbs Outdated
Comment thread src/partials/universal-nav.hbs
<div class="universal-nav" role="region" aria-label="Stackable network">
<div class="universal-nav__bar">
<a class="universal-nav__brand" href="{{{ relativize (versioned "home" page "index.html") }}}" aria-label="Stackable Documentation home">
<img class="universal-nav__logo" src="{{{uiRootPath}}}/img/stackable-mark.svg" alt="">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this right above the logo of the docs header looks really weird/overloaded. I would remove one of the two (most likely the one from the docs header as this universal nav bar seems to be the way forward).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but would do that as part of another PR to keep the scope about the universal header only.

@xeniape xeniape requested a review from Techassi July 1, 2026 10:03

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on resolved comments.

@xeniape xeniape merged commit d72dc30 into stackable Jul 2, 2026
2 checks passed
@xeniape xeniape deleted the feat/add-universal-header branch July 2, 2026 11:09
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

4 participants