Skip to content

feat(versioned): Add support for from_docs argument - #1293

Merged
Techassi merged 9 commits into
mainfrom
feat/from_docs
Oct 12, 2026
Merged

Techassi merged 9 commits into
mainfrom
feat/from_docs

Conversation

@sbernauer

@sbernauer sbernauer commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Description

Needed for a CRD change in trino-operator (Iceberg REST catalog client support).
Disclaimer: This was heavily AI-generated. I reviewed it and it looks good to me, but I don't really like macros, so happy if someone else disagrees, let them rewrite the entire thing 😅

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer changed the title feat(versioned): Add support for from_docs attribute feat(versioned): Add support for from_docs attribute Oct 6, 2026
@sbernauer sbernauer self-assigned this Oct 6, 2026
@sbernauer
sbernauer added this pull request to stack #1295 October 9, 2026 14:04
@Techassi
Techassi self-requested a review October 12, 2026 09:43
@Techassi Techassi changed the title feat(versioned): Add support for from_docs attribute feat(versioned): Add support for from_docs argument Oct 12, 2026
Techassi
Techassi previously approved these changes Oct 12, 2026
@Techassi
Techassi added this pull request to the merge queue Oct 12, 2026
Merged via the queue into main with commit bfa35cb Oct 12, 2026
5 checks passed
@Techassi
Techassi deleted the feat/from_docs branch October 12, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants