Amphorae build fixes - #2436
Conversation
04a9fe0 to
22fa65b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the Octavia Amphora image build playbook by setting the amphora_dib_upper_constraints_file variable to an empty string and moving python3-venv from common packages to OS-specific packages. The review feedback highlights two issues: first, python3-venv does not exist on RedHat-based systems and will cause installation failures, so it should be removed from the RedHat package list. Second, hardcoding amphora_dib_upper_constraints_file to an empty string prevents user overrides due to Ansible's variable precedence, and using a default filter is recommended instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
22fa65b to
cf8d441
Compare
| - name: Build an Octavia Amphora image | ||
| hosts: "{{ amphora_builder_group | default('seed') }}" | ||
| vars: | ||
| amphora_dib_upper_constraints_file: "{{ pip_upper_constraints_file }}" |
There was a problem hiding this comment.
nit: It would be better to set the default here given that the playbook relies on this variable being defined. Then -e on the command line still works.
eg. similar to this - just a comment used in the file included with -e:
https://github.com/openstack/kayobe/blob/master/etc/kayobe/overcloud-dib.yml#L76
python3-venv is not available on RH family systems.
cf8d441 to
1c7c878
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
🔇 Additional comments (3)
📝 WalkthroughUpdated Amphora image builds to use the latest Disk Image Builder. Added platform-specific package dependencies for Debian and Red Hat systems. Bumped the Amphora image version and configured the constraints setting. WalkthroughThe Amphora image build playbook now uses revised OS package definitions. The configuration updates the Amphora image version and adds an empty constraints setting. A release note documents the latest diskimage-builder default. ChangesAmphora image build
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Comment |
3 participants
Arguably, we should be using the latest DIB and not pinned to the OpenStack release. This ensures recent OS versions compatibility and generic fixes and improvements included.
Also, fix Ubuntu vs. Rocky dependencies installation.