Switch to Canonical Squid 7.2 image - #2476
Closed
Alex-Welsh wants to merge 1 commit into
Closed
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe seed configuration changes its Squid container image to Ubuntu Squid 7.2 on Ubuntu 26.04. A release note documents the image maintainer, version upgrade, and base distribution change. ChangesSquid container update
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
etc/kayobe/seed.yml (1)
142-144: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the tested image digest.
7.2-26.04_edgeis a channel tag. Docker Hub shows that its manifest was pushed recently. This indicates that later deployments can pull different image content without a repository change. Pin the digest used for validation, or add automated image-update testing. Verify that Kayobe’s separateimageandtagfields support the required digest reference. (hub.docker.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@etc/kayobe/seed.yml` around lines 142 - 144, Update the Squid image reference in the seed configuration around image and tag to use the digest corresponding to the validated ubuntu/squid image instead of the mutable 7.2-26.04_edge channel tag. Confirm Kayobe’s separate image and tag fields accept the digest format, preserving the existing image and pre configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@releasenotes/notes/ubuntu-squid-container-75698bf1b9535163.yaml`:
- Line 7: Correct the wording in the release note by changing “the new on is
based” to “the new one is based,” leaving the rest of the note unchanged.
---
Nitpick comments:
In `@etc/kayobe/seed.yml`:
- Around line 142-144: Update the Squid image reference in the seed
configuration around image and tag to use the digest corresponding to the
validated ubuntu/squid image instead of the mutable 7.2-26.04_edge channel tag.
Confirm Kayobe’s separate image and tag fields accept the digest format,
preserving the existing image and pre configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 292fefc8-ec9d-4590-9514-ac95085f4e0b
📒 Files selected for processing (2)
etc/kayobe/seed.ymlreleasenotes/notes/ubuntu-squid-container-75698bf1b9535163.yaml
Alex-Welsh
force-pushed
the
2026.1-bump-squid
branch
from
August 3, 2026 10:06
1864f0e to
4e418a8
Compare
Alex-Welsh
enabled auto-merge (rebase)
August 6, 2026 09:04
Member
|
Unfortunately the squid process doesn't start correctly: |
Member
Author
|
Ah, nuts. Well, I really don't have time to fix that now. Let's stick with what we have |
auto-merge was automatically disabled
August 11, 2026 13:01
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tested this new image. It looks like it should "just work", volumes mount in the same place etc.
If anyone wants to roll it out and try it, then that would be very much appreciated. Otherwise, I think it's a fairly safe switch
Summary by CodeRabbit