DNM: Create dist if it doesn't exist by Alex-Welsh · Pull Request #558 · stackhpc/stackhpc-release-train

Alex-Welsh · 2026-08-04T09:29:35Z

This PR is only up for discussion, not to be merged

Bumps Ansible pulp collections (pulp squeezer and our downstream ansible-collection-pulp) to the same versions we currently use in SKC. These should come with bugfixes and performance improvements. These now depend on pulp-glue and pulp-glue-deb pip packages, which have been added to requirements.txt

coderabbitai · 2026-08-04T09:29:52Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 90212035-7d34-4c4e-8d71-ef928751c56e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

✅ Review completed - (🔄 Check again to review again)

📝 Walkthrough

Updates Python setup and dependencies, including newer Pulp collections and pulp-glue packages. Enhances Debian and RPM repository tests to create a distribution when none exists, then re-query it.

Walkthrough

The setup now uses Python 3.12.x and installs updated Pulp packages and collections. Debian and RPM repository tests now select existing distributions, create missing distributions, and re-query them.

Changes

Pulp tooling setup

Layer / File(s)	Summary
Pulp tooling setup `.github/actions/setup/action.yml`, `requirements.txt`, `requirements.yml`	The setup uses Python 3.12.x and installs the declared requirements. The requirements add `pulp-glue`, `pulp-glue-deb`, and `setuptools`. The Ansible requirements use the Git-based Pulp collection and `pulp.squeezer` 0.3.0.

Distribution query flow

Layer / File(s)	Summary
Distribution query and creation flow `ansible/test-pulp-repo-version-query.yml`	Debian and RPM tasks collect matching distributions, select the first existing distribution, create one when none exists for the latest publication, and re-query after creation. Version fact expressions are reformatted.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant AnsibleTest as Ansible test
  participant DistributionQuery as Distribution query
  participant DistributionCreation as Distribution creation
  AnsibleTest->>DistributionQuery: collect matching distributions
  DistributionQuery-->>AnsibleTest: return distribution list
  AnsibleTest->>DistributionCreation: create distribution when none exists
  DistributionCreation-->>AnsibleTest: return created distribution
  AnsibleTest->>DistributionQuery: re-query distributions
  DistributionQuery-->>AnsibleTest: return updated distribution list

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7b9d3d0e-65eb-4758-a9c9-3bea5d7ba0a3

📥 Commits

Reviewing files that changed from the base of the PR and between 8b60c57 and eb7ceea.

📒 Files selected for processing (4)

.github/actions/setup/action.yml
ansible/test-pulp-repo-version-query.yml
requirements.txt
requirements.yml

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 59d21ccc-ade3-4c9d-b095-01278aca2dcf

📥 Commits

Reviewing files that changed from the base of the PR and between eb7ceea and ea54d7d.

📒 Files selected for processing (1)

ansible/test-pulp-repo-version-query.yml

coderabbitai · 2026-08-05T10:22:26Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

coderabbitai

Actionable comments posted: 8

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0703c0e2-ea0e-452b-8fac-84afc4670228

📥 Commits

Reviewing files that changed from the base of the PR and between 8b60c57 and 863d4e3.

📒 Files selected for processing (4)

.github/actions/setup/action.yml
ansible/test-pulp-repo-version-query.yml
requirements.txt
requirements.yml

coderabbitai · 2026-08-05T11:07:27Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

coderabbitai · 2026-08-05T11:57:45Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Alex-Welsh added 3 commits August 3, 2026 13:09

bodge

49a9da2

try branch 2

6a23b4e

Alex-Welsh requested a review from a team as a code owner August 4, 2026 09:29

coderabbitai Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread ansible/test-pulp-repo-version-query.yml Outdated

Comment thread requirements.yml

Try creating dist if it doesn't exist

282bafb

Alex-Welsh force-pushed the bump-squeezer-bodge branch 4 times, most recently from 9ca7402 to ea54d7d Compare August 4, 2026 14:21

Alex-Welsh marked this pull request as draft August 4, 2026 14:22

coderabbitai Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread ansible/test-pulp-repo-version-query.yml Outdated

Alex-Welsh force-pushed the bump-squeezer-bodge branch 5 times, most recently from 6dc9b09 to 863d4e3 Compare August 5, 2026 09:17

coderabbitai Bot reviewed Aug 5, 2026

View reviewed changes

Formatting

524a028

Alex-Welsh force-pushed the bump-squeezer-bodge branch from 863d4e3 to 524a028 Compare August 5, 2026 10:55

fix various issues

419f04c

Alex-Welsh force-pushed the bump-squeezer-bodge branch from 1f675fd to 419f04c Compare August 5, 2026 11:26

Alex-Welsh closed this Aug 5, 2026

Uh oh!

Conversation

Alex-Welsh commented Aug 4, 2026

Uh oh!

coderabbitai Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Aug 4, 2026 •

edited

Loading