Skip to content

Try creating dist if it doesn't exist - #559

Open
Alex-Welsh wants to merge 1 commit into
mainfrom
fix-missing-dist-sync
Open

Try creating dist if it doesn't exist#559
Alex-Welsh wants to merge 1 commit into
mainfrom
fix-missing-dist-sync

Conversation

@Alex-Welsh

Copy link
Copy Markdown
Member

When generating package repo version list, create a distribution when it doesn't exist for some reason.

When generating package repo version list, create a distribution when it
doesn't exist for some reason.
@Alex-Welsh
Alex-Welsh requested a review from a team as a code owner August 5, 2026 14:21
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 10a9e962-72ec-4b54-a9c0-ed470b8eb017

📥 Commits

Reviewing files that changed from the base of the PR and between 8b60c57 and 443126c.

📒 Files selected for processing (1)
  • ansible/test-pulp-repo-version-query.yml

📝 Walkthrough

Updated Debian and RPM repository version-list generation to handle missing publications and distributions safely. The playbook now matches timestamped distribution names, creates a missing distribution from the latest publication, re-queries distribution data, and guards display and fact-setting tasks.

Walkthrough

Changes

Pulp version queries

Layer / File(s) Summary
Resolve repositories and publications
ansible/test-pulp-repo-version-query.yml
Debian and RPM lookups now use safe list selection, empty defaults, and timestamp-tolerant distribution name matching.
Create and refresh distributions
ansible/test-pulp-repo-version-query.yml
Missing distributions are created only when a publication exists. Distribution data is re-queried before display and version facts are set.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant QueryTasks
  participant PulpAPI
  participant VersionFacts
  QueryTasks->>PulpAPI: query repositories, publications, and distributions
  PulpAPI-->>QueryTasks: matching lists or empty results
  QueryTasks->>PulpAPI: create missing distribution when publication exists
  PulpAPI-->>QueryTasks: distribution creation result
  QueryTasks->>PulpAPI: re-query distributions
  PulpAPI-->>VersionFacts: matching distribution data
  VersionFacts->>VersionFacts: display data and set version facts
Loading
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant