Try creating dist if it doesn't exist - #559
Open
Alex-Welsh wants to merge 1 commit into
Open
Conversation
When generating package repo version list, create a distribution when it doesn't exist for some reason.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughUpdated Debian and RPM repository version-list generation to handle missing publications and distributions safely. The playbook now matches timestamped distribution names, creates a missing distribution from the latest publication, re-queries distribution data, and guards display and fact-setting tasks. WalkthroughChangesPulp version queries
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant QueryTasks
participant PulpAPI
participant VersionFacts
QueryTasks->>PulpAPI: query repositories, publications, and distributions
PulpAPI-->>QueryTasks: matching lists or empty results
QueryTasks->>PulpAPI: create missing distribution when publication exists
PulpAPI-->>QueryTasks: distribution creation result
QueryTasks->>PulpAPI: re-query distributions
PulpAPI-->>VersionFacts: matching distribution data
VersionFacts->>VersionFacts: display data and set version facts
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating package repo version list, create a distribution when it doesn't exist for some reason.