Repository navigation
feat: populate Hostname and InternalDNS in StackitMachine addresses - #39
Open
breuerfelix wants to merge 1 commit into
Open
breuerfelix wants to merge 1 commit into
breuerfelix wants to merge 1 commit into
Conversation
tuunit
reviewed
Nov 17, 2026
| Address string | ||
| } | ||
|
|
||
| // Well-known server address types matching Cluster API conventions. |
Collaborator
There was a problem hiding this comment.
Lets add the contract url here:
Or github source file
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Populates both
HostnameandInternalDNSmachine address types with the server name (server.GetName()) inStackitMachine.status.addresses, aligning with upstream CAPI provider conventions (such as CAPO).Why it is needed
HostnameandInternalDNSalongsideInternalIPso consumers of CAPIMachine.status.addressescan correlate Kubernetes Nodes to Machines.cluster-machine-approvervalidates incoming kubelet certificate signing requests (CSRs) by matching the node name in the CSR subject (system:node:<node-name>) againstMachine.status.addressesentries of typeInternalDNSandHostname. Without these address types, CSR approval fails.