Skip to content

feat: populate Hostname and InternalDNS in StackitMachine addresses - #39

Open
breuerfelix wants to merge 1 commit into
mainfrom
hostname
Open

breuerfelix wants to merge 1 commit into
mainfrom
hostname

Conversation

@breuerfelix

Copy link
Copy Markdown
Member

What this PR does

Populates both Hostname and InternalDNS machine address types with the server name (server.GetName()) in StackitMachine.status.addresses, aligning with upstream CAPI provider conventions (such as CAPO).

Why it is needed

  1. CAPI Infrastructure Provider Contract: Upstream providers (CAPO, CAPA, CAPZ) populate Hostname and InternalDNS alongside InternalIP so consumers of CAPI Machine.status.addresses can correlate Kubernetes Nodes to Machines.
  2. Automated Kubelet CSR Approvals (OpenShift / OKD): OpenShift's cluster-machine-approver validates incoming kubelet certificate signing requests (CSRs) by matching the node name in the CSR subject (system:node:<node-name>) against Machine.status.addresses entries of type InternalDNS and Hostname. Without these address types, CSR approval fails.

@breuerfelix
breuerfelix requested a review from a team November 13, 2026 09:33
Comment thread cloud/types.go
Address string
}

// Well-known server address types matching Cluster API conventions.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants