Skip to content

Repository navigation

fix: preserve URL password when stripping iam_auth in get_db #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgrant merged 2 commits into from
Jun 15, 2026
Merged

fix: preserve URL password when stripping iam_auth in get_db #107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14bc98a
fix: preserve URL password when stripping iam_auth in get_db
wgrant Jun 13, 2026
c0a91e6
Merge branch 'stacklet/integration' into wgrant/fix/db-password-passt…
wgrant Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion redash/stacklet/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ def get_db(dburi, dbcreds=None, disable_iam_auth=False, schema=None):
return None
url = sqlalchemy.engine.url.make_url(dburi)
iam_auth = url.query.get("iam_auth")
url = sqlalchemy.engine.url.make_url(str(url).split("?")[0])
# Drop the iam_auth flag (it isn't a real connect arg) while preserving the
# rest of the URL. Don't round-trip through str(url): that renders the
# password as "***", so a plain user:password URL -- no iam_auth, no
# dbcreds -- would otherwise connect with a masked password and fail auth.
url = url.difference_update_query(["iam_auth"])
params = {"json_serializer": json.dumps}

# Add schema translation if schema is provided
Expand Down
Loading