Repository navigation
chore: bump default cli version to v0.5.38 - #11
Merged
Merged
Conversation
- Default to latest - Allow & resolve other target gitrefs - Update the default input value and README at the same time
|
PR author is not in the allowed authors list. |
ajkerrigan
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Addresses cubic review feedback on #11: - `sed -i` is not portable: BSD sed reads the following argument as a backup suffix, so `sed -i -E` silently loses ERE mode on macOS. Edits now go through a temp file that is copied back, preserving the target's inode and permissions. - Drop the `\t` separator from the extraction expression, since BSD sed emits a literal `t` there rather than a tab. - Quote the just parameter with `{{quote(ref)}}`; refs may legitimately contain `$()`, backticks or quotes, which were previously interpolated straight into the recipe's bash source. - Track updated files in a string rather than an array, which bash 3.2 on macOS treats as unset under `set -u`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBgEPS6veg5TYY4D48QgXb
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
The recipe had grown past what shell comfortably carries: the pin lives inside one input's block in action.yml and is repeated in the README table, so locating and rewriting it meant range-scoped sed expressions whose replacement text had to be escaped for sed's own metacharacters, with a separate portability layer because BSD and GNU sed disagree about in-place editing. Moving it to scripts/ follows what this repo already does with Python, and the parts worth trusting are now pure text transforms with tests around them: which line the pin lives on, what a commit is named when no tag points at it, and which files are actually out of step. Behaviour is unchanged, including per-file staleness checks and `latest` defaulting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
`just lint` was failing on five ruff errors the formatter doesn't touch: - ANN401 on four `Any` annotations. `fail` never returns, so it is `NoReturn`, which also lets its callers drop the `return fail(...)` dance they used to convince the type checker. The gh helpers really do hand back arbitrary decoded JSON, so that is now a named `Json` alias and the injectable seams are `Callable[[str], Json]`. - S607 on the literal `gh` in the subprocess argv. Resolving it through `shutil.which` fixes the partial path and gives a better home for the not-installed message than catching FileNotFoundError after the fact. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Addresses cubic review feedback on #11: - A README whose input row no longer matches substituted nothing, yet `apply` still counted the file as updated — the same false success the shell helper was faulted for, and inconsistent with `write_pin`, which already fails when the input block is missing. Fail on a zero-count substitution instead. - The unwritable-file test leaned on `chmod(0o444)`, which does not stop root and so would fail inside a root dev container. Deny the write directly instead, which tests the same code path for any user. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBgEPS6veg5TYY4D48QgXb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-8511
what
sinistral_cli_versiondefault value to the latestsinistral-clireleasewhy
To pull in recent fixes, and make it easier to avoid doc drift.
testing
This test ran successfully with these changes, and used the latest sinistral-cli.
docs
N/A